| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
They are promoting aspects of Offset not well-suited to graphics.
|
|
|
|
| |
This converts an angle in degrees into a unit vector.
|
|
|
|
| |
Multiples of 45 degrees should be returned exactly.
|
|
|
|
|
|
|
|
|
| |
std::vector::data().
Replace most code that reached into into Grob_array and modified its
internal vector with calls to new member functions such as filter().
Move the definitions of some trivial methods into grob-array.hh.
|
|
|
|
| |
This reverts commit f127e14af04f474d20406ca0e0f76f05061ee103.
|
|
|
|
| |
This reverts commit 59a6d1a06432fc0ca88c3023c646182f389ec1b5.
|
|
|
|
|
|
|
|
|
| |
These changes are produced by a rather long shell script that is
posted in the code review for this issue. Summary:
* remove "using namespace std;" everywhere
* add "std::" in *.hh and other included files
* add "std::" to functions and lesser-used types in *.cc files
|
|
|
|
|
|
|
|
|
| |
These are manual changes in preparation for an automated removal of
"using namespace std;".
Mostly these are additions of using-declarations for commonly used
types and containers (e.g. std::string, std::vector) to *.cc files so
that they will continue to build after the big removal.
|
|
|
|
|
| |
This is so that using-declarations can later be added without
appearing before #includes.
|
| |
|
| |
|
|
|
|
|
| |
Use for (DOWN_and_UP (d)) {...} instead.
Also replace the few uses of other_dir() with unary minus.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The compiler option -DNDEBUG is no longer being used: -DNDEBUG disables
the assert function, and assert is essentially stating that the program
cannot useful continue if the assertion is not met. -DNDEBUG is
basically an option for compiling an application to a limited amount of
ROM when aborting with a diagnostic is not preferable to crashing.
This is not the case for LilyPond. So expensive debugging options now
are enabled with -DDEBUG instead. There is a new configure option
--enable-checking defaulting to "off" for this now.
At the current point of time, setting --disable-optimising also has the
effect of enabling the checks: this will be retained until Patchy has
been adapted to using --enable-checking.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 4346
Remove cygwin_conv_to_posix_path
cygwin_conv_to_posix_path is
deprecated on cygwin (32bit) and
not available on cygwin64.
It is not needed in a pure
cygwin environment.
|
|
|
|
|
| |
This reverses part of commit 19125bf1, which said that (r-s).sign() was
too expensive, but I saw no change (within 0.1%) in compilation times.
|
| |
|
|
|
|
| |
The error behavior is not useful and triggers on things like "00".
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++ string manipulation is a fragile bolt-on onto the type system.
"-" + 'd'
evaluates to a pointer 100 bytes after a constant string "-" in the data
section. This fixes this bug, and also changes the fixed message from
lilypond: option `-d, `--define-default'' requires an argument
to
lilypond: option `-d, --define-default' requires an argument
In general, it does not appear to make sense quoting the long options
while not quoting the short options.
|
|
|
|
| |
Provided by Felix Janda
|
|
|
|
| |
Run make grand-replace to update all coopyright statements
|
| |
|
|
|
|
| |
std-vector.hh did not include config.hh but relied on it
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
makes sense to avoid unnecessary copying of 'string' objects.
Measurements on x86_64 (i7-2760QM, 2.40GHz) Fedora 19 with g++ 4.8.1, with
configure --enable-optimising --disable-debugging; tests run 10 times, average
elapsed time compared (/usr/bin/time)
* Bach, Concerto in E major or violin and strings, BWV 1042 (Mutopia source),
38 pages:
$ lilypond score.ly -> master: 15.4s, with patch: -0.1%
* lilypond regression tests (1153 .ly files):
$ lilypond *.ly -> master: 276.6s, with patch: -2.5%
|
|
|
|
| |
defined and stream.hh
|
|
|
|
|
|
|
|
|
|
|
|
| |
The V2.17.0 definition of ly_module_lookup in module-scheme.cc uses two
functions, scm_sym2var and scm_module_lookup_closure, which issue
deprecation warnings in Guile V2.06. A call to the new Guile API function,
scm_module_variable, provides the functionality for both deprecated
routines, but has not been back-ported to Guile V1.8.
This patch adds a conditionally-compiled block when running with a Guile
version < V2.0, so that Guile V1 will not use the deprecated scm_ calls
in ly_module_lookup, and Guile V2 will use API call scm_module_variable.
|
|
|
|
|
|
| |
results of the following searches were checked manually:
grep -rE -e 'const( +[a-zA-Z0-9_]*)? *, *$' .
grep -rE -e 'const( +[a-zA-Z0-9_]*)?( *,[^;]+)?\) *(const|= *0)? *;' .
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The file stencil-integral.cc provides a suite of functions that
traverse a stencil and do linear approximations of its components.
These are then turned into boxes that are passed to the Skyline
constructor. This approximation is used for several vertical skylines
including those of VerticalAxisGroup and System. As a result of these
more accurate approximations, vertical spacing is more snug between
grobs.
Additionally, in axis-group-interface.cc, skylines of grobs are no
longer compared to a monolithic axis-group skyline but rather all
of the component skylines of the axis-group, allowing grobs to
be fit under other ones if there is space instead of always shifted over.
Two new python scripts allow to visualize the position of skylines.
All other changes provide functions that allow for better debugging
of Skylines, better approximations of grobs via skylines, and changes
to the measurement of distance between grobs via the new Skyline API.
This results in a significant time increase in score compilation for
objects with complex skylines such as all text grobs. For orchestral
scores, the increase is not as steep.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the requirement of having a GNUmakefile
in each and every directory of the source tree; this commit
also deletes GNUmakefiles made unnecessary this way.
dist-toplevel-txt-files toplevel target is also removed,
because it is unneeded outside of dist target and it
prevents linking of toplevel generated txt docs to
distdir when these docs are already generated.
In addition, on suggestions from Han-Wen, if dist is made with a
source directory tracked by Git, then
* the source directory is required to have no uncommitted changes nor
non-ignored untracked files,
* the time stamp of all files in the tarball is set to the time stamp
of the head of the checked-out branch.
|
| |
|
| |
|
|
|
|
|
|
| |
Replaces do{ ... } while(flip (&d) != DOWN/UP/... with a macro for(DOWN_and_UP/UP_and_DOWN/....) { }
Signed-off-by: David Kastrup <dak@gnu.org>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
"According the ANSI/ISO Standard, the use of access declarations
is considered deprecated. Instead, you should use a using
declaration for that purpose"
http://www.devx.com/tips/Tip/5707
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang++ complains about this, and we never rely on the default
comparison in our code.
/home/gperciva/src/lilypond/flower/include/std-vector.hh:197:36:
error: 'T' does
not refer to a value
Compare less = less<T> (),
^
/home/gperciva/src/lilypond/flower/include/std-vector.hh:193:19:
note: declared
here
template<typename T, typename Compare>
^
/home/gperciva/src/lilypond/flower/include/std-vector.hh:197:40:
error:
expected expression
Compare less = less<T> (),
|
|
|
|
|
|
|
|
| |
/home/gperciva/src/lilypond/flower/file-cookie.cc:45:50: error: implicit
conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long')
[-Werror,-Wsign-conversion]
return Memory_out_stream::writer (file, buf, i);
~~~~~~~~~~~~~~~~~ ^
|
| |
|
| |
|
|
|
|
|
|
|
| |
Most of the remaining warnings are about vsize -> int casting,
where I'll have to find a proper solution (we don't want to cast
all appearances of vsize to int explicitly, but rather use vsize
wherever possible).
|
|
|
|
| |
This finally makes that option apply to ALL warnings, and it considerably cleans up the error/warning functions.
|
| |
|