diff options
author | Mike Gran <spk121@yahoo.com> | 2019-02-09 16:39:19 -0800 |
---|---|---|
committer | Mike Gran <spk121@yahoo.com> | 2019-02-09 16:39:19 -0800 |
commit | 1437b76777e576b3d000e2f80c5ecdb33a74ac33 (patch) | |
tree | 1cf53c670e6bbeac6732482bce7acb62189de53b /test-suite | |
parent | 139c702fc8b61fdeb813c3428fef3701ea8677f9 (diff) |
Avoid leaking a file descriptor in test-unwind
* test-suite/standalone/test-unwind.c (check_ports): explicitly close temp file
Diffstat (limited to 'test-suite')
-rw-r--r-- | test-suite/standalone/test-unwind.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/test-suite/standalone/test-unwind.c b/test-suite/standalone/test-unwind.c index 3aa3e159d..2749af276 100644 --- a/test-suite/standalone/test-unwind.c +++ b/test-suite/standalone/test-unwind.c @@ -1,4 +1,4 @@ -/* Copyright (C) 2004, 2005, 2008, 2009, 2010, 2013 Free Software Foundation, Inc. +/* Copyright (C) 2004, 2005, 2008, 2009, 2010, 2013, 2019 Free Software Foundation, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License @@ -200,6 +200,7 @@ check_ports () #define FILENAME_TEMPLATE "/check-ports.XXXXXX" char *filename; const char *tmpdir = getenv ("TMPDIR"); + int fd; #ifdef __MINGW32__ extern int mkstemp (char *); @@ -221,8 +222,10 @@ check_ports () /* Sanity check: Make sure that `filename' is actually writeable. We used to use mktemp(3), but that is now considered a security risk. */ - if (0 > mkstemp (filename)) + fd = mkstemp (filename); + if (fd < 0) exit (EXIT_FAILURE); + close (fd); scm_dynwind_begin (0); { |