summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorNoam Postavsky <npostavs@gmail.com>2016-09-03 23:38:35 -0400
committerNoam Postavsky <npostavs@gmail.com>2016-09-10 09:13:09 -0400
commit68f4b5292781bc331b040105c4079902b993835c (patch)
tree41915edb4e3077ad99539b04c2b7be51a1b1a8fe /test
parent367f8568bc9e759ebdfb423648891efa0346456b (diff)
Don't require isearch-update before isearch-done
It is useful to be able to call `isearch-done' unconditionally to ensure a non-isearching state. * lisp/isearch.el (isearch-done): Check that `isearch--current-buffer' is a live buffer before using it (Bug #21091). * test/lisp/isearch-tests.el (isearch--test-done): Test it.
Diffstat (limited to 'test')
-rw-r--r--test/lisp/isearch-tests.el8
1 files changed, 8 insertions, 0 deletions
diff --git a/test/lisp/isearch-tests.el b/test/lisp/isearch-tests.el
index 48c342403c..52f312d0b9 100644
--- a/test/lisp/isearch-tests.el
+++ b/test/lisp/isearch-tests.el
@@ -28,5 +28,13 @@
(isearch-update)
(should (equal isearch--current-buffer (current-buffer)))))
+(ert-deftest isearch--test-done ()
+ ;; Normal operation.
+ (isearch-update)
+ (isearch-done)
+ (should-not isearch--current-buffer)
+ ;; Bug #21091: let `isearch-done' work without `isearch-update'.
+ (isearch-done))
+
(provide 'isearch-tests)
;;; isearch-tests.el ends here