diff options
| author | Noam Postavsky <npostavs@gmail.com> | 2016-07-03 09:56:36 -0400 |
|---|---|---|
| committer | Noam Postavsky <npostavs@gmail.com> | 2016-07-03 15:05:20 -0400 |
| commit | 178b2f590982e37991bc72b08a9e02b64d750601 (patch) | |
| tree | bbc08a39311cd65d9870376dda28de3d451efb16 /lisp | |
| parent | dec756756070d271925c8c2a705de97eb8d7fb0b (diff) | |
Note combine-and-quote-strings doesn't shell quote
* doc/lispref/processes.texi (Shell Arguments):
* lisp/subr.el (combine-and-quote-strings): Add a note that
combine-and-quote-strings doesn't protect arguments against shell
evaluation (Bug #20333).
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/subr.el | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lisp/subr.el b/lisp/subr.el index ed2166a0ee..e9e19d35f6 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3706,7 +3706,10 @@ Modifies the match data; use `save-match-data' if necessary." "Concatenate the STRINGS, adding the SEPARATOR (default \" \"). This tries to quote the strings to avoid ambiguity such that (split-string-and-unquote (combine-and-quote-strings strs)) == strs -Only some SEPARATORs will work properly." +Only some SEPARATORs will work properly. + +Note that this is not intended to protect STRINGS from +interpretation by shells, use `shell-quote-argument' for that." (let* ((sep (or separator " ")) (re (concat "[\\\"]" "\\|" (regexp-quote sep)))) (mapconcat |