summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGlenn Morris <rgm@gnu.org>2010-02-17 22:18:49 -0800
committerGlenn Morris <rgm@gnu.org>2010-02-17 22:18:49 -0800
commitd9aa39cc6e22da67a6a0c520e9ea1e620ac55bbd (patch)
tree28ba0cf18cee33bb05aa5a820e02d2bd0d18c472
parentb788a98d136af5e841e8e521f6900b703a294743 (diff)
* commits: Mention not to mix changes in any given commit.
-rw-r--r--admin/notes/commits8
1 files changed, 8 insertions, 0 deletions
diff --git a/admin/notes/commits b/admin/notes/commits
index 2896328c66..f37c3e020b 100644
--- a/admin/notes/commits
+++ b/admin/notes/commits
@@ -1,10 +1,17 @@
HOW TO COMMIT CHANGES TO EMACS
+Most of these points are from:
+
http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00555.html
From: Miles Bader
Subject: commit style redux
Date: Tue, 31 Mar 2009 12:21:20 +0900
+(0) Each commit should correspond to a single change (whether spread
+ over multiple files or not). Do not mix different changes in the
+ same commit (eg adding a feature in one file, fixing a bug in
+ another should be two commits, not one).
+
(1) Commit all changed files at once with a single log message (which
in CVS will result in an identical log message for all committed
files), not one-by-one. This is pretty easy using vc-dir now.
@@ -41,6 +48,7 @@ Date: Tue, 31 Mar 2009 12:21:20 +0900
Followup discussion:
http://lists.gnu.org/archive/html/emacs-devel/2010-01/msg00897.html
+http://lists.gnu.org/archive/html/emacs-devel/2010-02/msg00401.html
PREVIOUS GUIDELINES FOR CVS